properties - PHP CodeSniffer property not recognized -



properties - PHP CodeSniffer property not recognized -

my sniff doesn't work , doesn't recognize property private $testvar. want create doc-block mandatory there.

when run code sniffer, process method doesn't seem used. added echos there before.

does token t_property exist? cannot find on php manual http://php.net/manual/en/tokens.php yet, in squiz lab source code t_property used.

<?php /** * extension pear class comment sniff. * */ /** * extension pear class comment sniff. * */ class xyz_sniffs_commenting_propertycommentsniff implements php_codesniffer_sniff { private $testvar = 1; /** * returns array of tokens test wants hear for. * * @return array */ public function register() { homecoming array(t_property); } /** * checks property comments. * * @param php_codesniffer_file $phpcsfile file object * @param int $stackptr stack pointer * * @return void */ public function process(php_codesniffer_file $phpcsfile, $stackptr) { $tokens = $phpcsfile->gettokens(); $find = php_codesniffer_tokens::$scopemodifiers; $find[] = t_whitespace; $find[] = t_static; $commentend = $phpcsfile->findprevious($find, ($stackptr - 1), null, true); if ($tokens[$commentend]['code'] !== t_doc_comment_close_tag && $tokens[$commentend]['code'] !== t_comment ) { $phpcsfile->adderror('missing property doc comment', $stackptr, 'missing'); $phpcsfile->recordmetric($stackptr, 'function has property comment', 'no'); return; } else { $phpcsfile->recordmetric($stackptr, 'function has property comment', 'yes'); } } }

thanks help :).

the t_property token used when checking javascript files. doesn't exist php files.

for php files, you'll want utilize abstractvariablesniff helper. here sniff checks comments of fellow member vars: https://github.com/squizlabs/php_codesniffer/blob/master/codesniffer/standards/squiz/sniffs/commenting/variablecommentsniff.php

notice how extends php_codesniffer_standards_abstractvariablesniff , implements processmembervar() method. leaves processvariable() , processvariableinstring() methods empty because doesn't care regular variables within code.

also note if writing commenting sniffs, comment parser different in 2.0 version (currently in beta due go stable week now). take @ new version of above sniff here: https://github.com/squizlabs/php_codesniffer/blob/phpcs-fixer/codesniffer/standards/squiz/sniffs/commenting/variablecommentsniff.php

php properties token codesniffer sniffer

Comments

Post a Comment

Popular posts from this blog

Delphi change the assembly code of a running process -

Delphi change the assembly code of a running process - i'm trying alter address 00741fa5 has push test.009e721c . alter push test.009e71c8 . procedure callback; asm force $9e71c8 end; procedure tform2.btn1click(sender: tobject); var ppid :dword; pprocess : cardinal; begin getwindowthreadprocessid(findwindow(nil,pchar('test')), @ppid); pprocess := openprocess(process_all_access, false, ppid); injectasm(pprocess, $741fa5, 10, integer(@callback), 0); end; here injectasm function (with error checking) function injectasm(process: longword; injectaddress, injectsize, codeaddress, codesize : integer): pointer; var csize, rsize : integer; replaced : array of byte; jmp : array [0..4] of byte; jmpaddress : integer; nopv : byte; : integer; nbr: ulong_ptr; begin //injectsize must equal or greater 5, because need space our //(far) jmp wwxxyyzz instruction //if there's no space, inject in place of few instructions if injectsize ...
Read more

json - Hibernate and Jackson (java.lang.IllegalStateException: Cannot call sendError() after the response has been committed) -

json - Hibernate and Jackson (java.lang.IllegalStateException: Cannot call sendError() after the response has been committed) - hello have problem hibernate , jackson. have 2 pojos @entity @table(name = "users") public class user implements serializable { static final long serialversionuid = 4235637833262722256l; @id @generatedvalue private int id; @column(name = "creation_date") private date creationdate; @column(name = "first_name") private string firstname; @column(name = "last_name") private string lastname; @version @column(name = "version") private int version; @column(name = "e_mail") private string email; @column(name = "enabled") private boolean enabled; @column(name = "login") private string login; @column(name = "password") private string password; @jsonmanagedreference("role") @onetomany(mappedby = "user", cascade = cascadetype.all,fetch = fetchtyp...
Read more

C++ 11 "class" keyword -

C++ 11 "class" keyword - i've started using c++ 11 little bit more , have few questions on special uses of class keyword. know it's used declare class, there's 2 instances have seen don't understand: method<class t>(); and class class_name *var; why precede typename keyword class in first example, , keyword pointer in sec example? that known elaborated type specifier , necessary when class name "shadowed" or "hidden" , need explicit. class t { }; // love of god don't t t; t t2; if compiler smart, give these warnings: main.cpp:15:5: error: must utilize 'class' tag refer type 't' in scope t t2; ^ class main.cpp:14:7: note: class 't' hidden non-type declaration of 't' here t t; ^ if class not defined, deed forwards declaration. for example: template <typename t> void method() { using type = typename t::value_type; } method...
Read more