php - is this the proper way to return 2 fields from a DB? -

php - is this the proper way to return 2 fields from a DB? -

i able user id through separate view , controller in instance trying list of users , display screen. problem lies somewhere in getuserarray function or perchance getuser function. not proficient plenty spot though. getuserbyid function doesnt phone call getuserarray() or getuser() , works fine.there no fields in db called "user" of 3 fields select statement want grab , display.

//userdb.class.php public static function getall() { $query = "select userid, userfirstname, userlastname users grouping userid"; $users = array(); seek { $db = database::getdb (); $statement = $db->prepare($query); $statement->execute (); $users = userdb::getuserarray($statement->fetchall(pdo::fetch_assoc)); $statement->closecursor (); } grab ( pdoexception $e ) { // not permanent error handling echo "<p>error getting users ".$e->getmessage()."</p>"; } homecoming $users; } public static function getuserarray($rowsets) { $users = array (); foreach ( $rowsets $userrow ) { $user = userdb::getuser($userrow); array_push ( $users, $user ); } homecoming $users; } public static function getuser($userrow) { // homecoming comment object rowset. homecoming new userdata ( $userrow ); } //userdata.class.php // responsibility: holds info comment , performs validation // constructor expects associative array field values initialization <?php class userdata { private $userid; private $user; private $userfirstname; private $userlastname; public function __construct($forminput) { $this->initialize($forminput); } public function getuser() { homecoming $this->user; } public function getuserfirstname(){ homecoming $this->userfirstname; } public function getuserlastname(){ homecoming $this->userlastname; } public function getuserid() { homecoming $this->userid; } public function getparameters() { // homecoming info fields associative array $paramarray = array("userid" => $this->userid, "userfirstname" => $this->userfirstname, "userlastname" => $this->userlastname ); homecoming $paramarray; } public function printuser() { echo "<h1>shield member</h1>"; echo "user id: $this->userid<br>"; echo "user first name: $this->userfirstname<br>"; echo "user lastly name: $this->userlastname<br>"; } private function initialize($forminput) { if (isset($forminput['userid'])) $this->userid = $forminput['userid']; else $this->userid = 0; if (isset($forminput['userfirstname'])) $this->userfirstname = $forminput['userfirstname']; if (isset($forminput['userlastname'])) $this->userlastname = $forminput['userlastname']; } } ?> //userscontroller.php <?php include_once("../views/showusers.php"); include_once("../models/userdb.class.php"); include_once("../models/userdata.class.php"); include_once("../models/database.class.php"); $myusers = userdb::getall(); showusers($myusers, "all users"); ?> //showusers.php // displays list of users // input: array of commentdata objects <?php function showusers($userlist, $msg) { echo "<h1>".$msg."</h1>"; foreach ($userlist $user) { $user->printuser(); } echo '<h3><a href="../index.php">back home</a>'; } ?>

php mysql